Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dot-path #210

Closed
drernie opened this issue Jun 15, 2024 · 3 comments · Fixed by #211
Closed

dot-path #210

drernie opened this issue Jun 15, 2024 · 3 comments · Fixed by #211
Assignees

Comments

@drernie
Copy link
Member

drernie commented Jun 15, 2024

The newer nf-schema plugin seems to create relative URIs of the form:

quilt+s3://./

This breaks all our semantics. We should try to reproduce, then fix.

@drernie drernie self-assigned this Jun 15, 2024
@drernie
Copy link
Member Author

drernie commented Jun 16, 2024

Jun-14 19:16:54.756 [main] DEBUG nextflow.Session - Session aborted -- Cause: Cannot invoke 
Jun-14 19:16:54.742 [main] DEBUG nextflow.quilt.nio.QuiltPath - Creating QuiltPath: bfx-input?initiative=index&tpdi_id=TPDI-292#package=index-fetchngs%2fcellarity-nfcore-fetchngs_tpdi-292
Jun-14 19:16:54.747 [main] WARN  nextflow.quilt.jep.QuiltID - QuiltID.fetch: setting missing package to null
Jun-14 19:16:54.748 [main] WARN  nextflow.quilt.jep.QuiltID - QuiltID.fetch: setting missing package to null
Jun-14 19:16:54.748 [main] DEBUG nextflow.file.FileHelper - Creating a file system instance for provider: QuiltFileSystemProvider
Jun-14 19:16:54.748 [main] WARN  nextflow.quilt.jep.QuiltID - QuiltID.fetch: setting missing package to null
Jun-14 19:16:54.748 [main] WARN  nextflow.quilt.jep.QuiltID - QuiltID.fetch: setting missing package to null
Jun-14 19:16:54.748 [main] DEBUG nextflow.quilt.nio.QuiltPath - Creating QuiltPath: .
Jun-14 19:16:54.752 [main] DEBUG nextflow.quilt.nio.QuiltFileSystem - QuiltFileAttributes QuiltFileSystem.readAttributes(.)

"nextflow.quilt.jep.QuiltPackage.packageDest()" because the return value of "nextflow.quilt.nio.QuiltPath.pkg()" is null
Jun-14 19:16:54.767 [main] ERROR nextflow.cli.Launcher - @unknown
java.lang.NullPointerException: Cannot invoke "nextflow.quilt.jep.QuiltPackage.packageDest()" because the return value of "nextflow.quilt.nio.QuiltPath.pkg()" is null
	at nextflow.quilt.nio.QuiltPath.localPath(QuiltPath.groovy:77)
	at nextflow.quilt.nio.QuiltFileSystem.readAttributes(QuiltFileSystem.groovy:110)
	at nextflow.quilt.nio.QuiltFileSystemProvider.readAttributes(QuiltFileSystemProvider.groovy:484)

@drernie
Copy link
Member Author

drernie commented Jun 16, 2024

Unfortunately, the schema code implicitly assumes that "." is a valid path. The call stack is deep enough we have to synthesize one rather than returning null. The best way I can think to do that is to create a /dev/null bucket that warns but does not error.
nf-4NtJKIDX7uGWX5.log

@drernie
Copy link
Member Author

drernie commented Jun 17, 2024

arn:aws:s3:::nf-quilt-dev-null

WARNING: you are attempting to write to a non-existent bucket

@drernie drernie mentioned this issue Jun 17, 2024
@drernie drernie linked a pull request Jun 17, 2024 that will close this issue
drernie added a commit that referenced this issue Jun 17, 2024
#210 

Use nf-quilt-dev-null bucket for relative paths
And don't try to act on it.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant