Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

manual configuration #185

Open
drernie opened this issue Feb 12, 2024 · 4 comments
Open

manual configuration #185

drernie opened this issue Feb 12, 2024 · 4 comments
Assignees

Comments

@drernie
Copy link
Member

drernie commented Feb 12, 2024

Right now we:

  • use the URI to pass in all the information
  • scrape the Params file to match the original URI with the generated QuiltPath

This is already brittle, and breaks completely for dynamically-generated URIs.

We should have the option to manually specify all the relevant parameters, and use those when available.
This is how it was done for the original Seqera-built nf-quilt plugin:

quilt {
  packageName = 'genomes/yeast'
  registry = 's3://seqera-quilt'
  message = 'My commit message'
  meta = [pipeline: 'nf-core/rnaseq']
  force = false
}
@drernie drernie self-assigned this Feb 12, 2024
@w-osman-orion
Copy link

I am assuming this would be for the package the data is published to. If so, it would be great to have the additional following options:

  • Skip metadata (i.e. use the existing metadata if the package is already created)
  • Skip Readme creation
  • include a parameter for the path within the quilt package

Also, I am not sure if this addresses the issue, as I was parsing the input parameters to dynamically create the URI's for both the inputs and outputs to the nf workflow.

@drernie
Copy link
Member Author

drernie commented Feb 13, 2024

You are right, it makes much more sense to have those application-specific configuration parameters inside your NextFlow configuration, rather than inside the URI.

The way this solves your dynamic URI problem is that right now nf-quilt tries to use the package name (from the path) to find the original output URI from the parameters file. Which fails because your inputs and outputs are from the same package are not in the parameters file.

This way:

  1. nf-quilt can look at the config struct, rather than the params file, and
  2. you can explicitly tell nf-quilt which output URI to use, and
  3. you can simply embed the metadata in the config file (which is the actual bug you are facing ,right?)

@w-osman-orion
Copy link

Yes, that is the bug I am facing.

@drernie
Copy link
Member Author

drernie commented Nov 8, 2024

Hopefully this is fixed by 0.8.11. Please let us know.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants