Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update scuttlebutt version and add configurable cluster_name #1283

Closed
fulmicoton opened this issue Apr 12, 2022 · 0 comments · Fixed by #1284
Closed

Update scuttlebutt version and add configurable cluster_name #1283

fulmicoton opened this issue Apr 12, 2022 · 0 comments · Fixed by #1284
Assignees
Labels
bug Something isn't working

Comments

@fulmicoton
Copy link
Contributor

In quickwit-oss/chitchat#36 we added a cluster_name to scuttlebutt.

This is meant to avoid having two clusters merge due to a misconfiguration or k8s IP recycling.
We need to update scuttlebutt, and set the cluster_name properly (probably add that in the quickwit_config.)

@fulmicoton fulmicoton added the bug Something isn't working label Apr 12, 2022
@xvello xvello self-assigned this Apr 12, 2022
fulmicoton pushed a commit that referenced this issue Apr 20, 2022
fulmicoton pushed a commit that referenced this issue Apr 20, 2022
Make the cluster_id settable to avoid several clusters merging accidentally chitchat#36

Add the optional cluster_id config param, with a default value of "quickwit-test-cluster"
Add a new unit test to confirm that four nodes with different cluster names settle correctly into 2x2
How was this PR tested?
Only unit test for now, we should test it a bit more manually before the v0.3 release

Closes #1283
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants