New theme option: Lyrics all uppercase #246
Conversation
Many modern worship presentations have their lyrics entirely in uppercase. Whilst I like the look of such presentations, I don't like the thought of haveing the lyrics just in uppercase in the database. With this feature, you can press a new button in the theme-editor, which toggles the uppercase-mode. The lyrics in the database isn't changed at all, it happens purely at rendering
The prior changes on TextSection were unnecessary for the uppercase-lyrics-feature
When designs call the "old" constructor, which is missing the parameter isUppercase, the theme-value will set to be false.
|
I don't know if I should edit my code due to the "bad" rating Codacy gives me, because it highlights some code that was used in the exact same way multiple times in the original file before... |
|
Don't worry about Codacy for now. We'll take a closer look after 2020.0 is released, for now however our priority is getting that out the door. |
|
@berry120 don't you plan to take a look at this feature? It's very useful in some cases, including our church |
|
@kukymbr While I'm open to it I'm still somewhat struggling to see the wider use of it - but if you could explain how it's helpful in your context that'd be useful. Is it just a style preference, or an accessibility thing, or something else? As always it's the balance between trying to bring in whatever is helpful, while not bringing in every feature under the sun that only one or two people would ever end up using. If this genuinely has a valid use case for a fair number of people then I'm happy to incorporate it, but I usually take "ALL CAPS" style to be less readable, and more "shouty" looking. |
|
@berry120 I agree about the "shouty" looking. But we used the all-caps style (when we were using the EasyWorship), because we had not a big enough screen nor bright enough projector and a lot of our visitors are people in age. So capitalised letters were helping them to read the text. Now we fixed the problem by buying the more modern TV, but pretty much of churches that I know in our region have the same issue with an equipment. |
With this new feature it is now possible to render the lyrics (and translation seperatly) all in UPPERCASE letters, whilst the lyrics in the database is still correctly formatted. See Issue #219