Introduce poll-interval-variance option #431
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tomgi
commented
Sep 20, 2024
| @@ -275,7 +275,7 @@ def assert_poll(priorities:, locked:) | |||
| assert_equal false, poller.should_poll? | |||
| end | |||
|
|
|||
| it "should be false if the number of jobs returned from the last poll was less than the lowest priority request, but the poll_interval has elapsed" do | |||
| it "should be true if the number of jobs returned from the last poll was less than the lowest priority request, but the poll_interval has elapsed" do | |||
There was a problem hiding this comment.
That was a typo, the test is actually checking assert_equal true, which is the expected behavior.
tomgi
commented
Sep 24, 2024
| job_ids = 5.times.map { Que::Job.enqueue.que_attrs[:id] } | ||
|
|
||
| result = poller.poll(priorities: { 500 => 7 }, held_locks: Set.new) | ||
| assert_equal job_ids, result.map(&:id) | ||
|
|
||
| poller.instance_variable_set(:@last_polled_at, Time.now - 30) | ||
| assert_equal true, poller.should_poll? | ||
| Timecop.freeze(Time.now + 30) do |
There was a problem hiding this comment.
This change makes the spec less coupled with implementation details.
Instead of setting private instance variables, it 'time travels' 30 seconds into the future, after the poll_interval has already elapsed.
tomgi
force-pushed
the
poll-interval-variance
branch
from
c23171b to
5e50c41
Compare
tomgi
force-pushed
the
poll-interval-variance
branch
from
5e50c41 to
6ccd8bc
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Enable this for cleaner diff:
Context
We run multiple ECS tasks of que that are all started almost exactly at the same time during every deployment.
That means that they also start polling at the same time, and continue doing so in such a synchronized fashion.
More specifically, in our case:
poll-intervalis set to 20sMeaning that on average we poll every 5s, but in reality, we poll 4 times every 20s 🙂
We would like to introduce a random variance to the polling interval, so that the polling is more evenly distributed.
Changes
Add optional
poll-interval-varianceCLI parameter defaulting to 0.0.It is used to make each individual poll time slightly randomised within the range of
poll-interval +/- poll-interval-variance.This way tasks started at the same time won't continue always polling at the same time.
Backward-compatibility
When the new
poll-interval-varianceparameter is not provided, there's no change compared to the current behaviour.