Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/Show pending transactions from appstore until they return from qubic live #190

Open
wants to merge 21 commits into
base: develop
Choose a base branch
from

Conversation

ahmed-tarek-salem
Copy link
Contributor

@ahmed-tarek-salem ahmed-tarek-salem commented Oct 28, 2024

  • Show pending transactions from App store
  • Show rejected transactions from App store after their tick is passed
  • Add delete option for Failed transactions
  • Add the ability to resend transactions if the origin is one of the user accounts
  • Add local storage to save both types of transactions

Closes #139

@ahmed-tarek-salem ahmed-tarek-salem changed the title feat: Show pending transactions from appstore until they return from qubic live Feature/Show pending transactions from appstore until they return from qubic live Oct 28, 2024
@sallymoc
Copy link
Contributor

sallymoc commented Oct 29, 2024

@ahmed-tarek-salem Please add the option to Delete in the actions for the Failed-invalid ones (meaning, the ones never included in the network and whose tick is in the past).

@sallymoc
Copy link
Contributor

sallymoc commented Nov 8, 2024

@ahmed-tarek-salem

  • Please ensure all the trx listed are sorted by tick desc
    image

  • Please remove the word 'failed' from the Resend popup. if possible, please do it for all the languages
    image

  • Please ensure that "Failed-Invalid" is displayed for the trx that were not added to the network (i.e stored locally only whose tick is lower than current ticket) and "Failed" for the ones with amount > 0 and moneyFlew false.

  • Please remove in the app the references to "Confirmed" status. It doesn't exist in the new services

@ahmed-tarek-salem
Copy link
Contributor Author

@sallymoc

Done, Please check.

For this:

Please ensure that "Failed-Invalid" is displayed for the trx that were not added to the network (i.e stored locally only whose tick is lower than current ticket) and "Failed" for the ones with amount > 0 and moneyFlew false.

That wasn't the case in the app, it was the opposite. I reversed it but to work with you properly please clear all old ignored transactions first.

@sallymoc
Copy link
Contributor

@ahmed-tarek-salem Please remove the action "View in Explorer" for the failed-invalid transactions

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

To store locally the submitted transactions until they are returned by the network
2 participants