Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

admin: add pre v4.8.0 admin command to delete OVAL vulns #2127

Merged
merged 1 commit into from
Sep 13, 2024

Conversation

crozzy
Copy link
Collaborator

@crozzy crozzy commented Aug 30, 2024

The migration to delete OVAL vulnerabilities can take a while (10 mins plus depending on resources). This patch adds a command to pre-delete the vulnerabilities after adding the migration version entry.

@crozzy crozzy requested a review from a team as a code owner August 30, 2024 19:13
@crozzy crozzy requested review from hdonnay and removed request for a team August 30, 2024 19:13
@crozzy crozzy force-pushed the admin-delete-oval branch 2 times, most recently from 86185ab to 62a4dc8 Compare September 9, 2024 22:20
@hdonnay
Copy link
Member

hdonnay commented Sep 11, 2024

I think this should be a pre job to make an entry in the migrations table, and a post job to do the deletions.

As is, this leaves a (larger) period of time where there will be incorrect results for RHEL.

@crozzy
Copy link
Collaborator Author

crozzy commented Sep 11, 2024

I think this should be a pre job to make an entry in the migrations table, and a post job to do the deletions.

As is, this leaves a (larger) period of time where there will be incorrect results for RHEL.

We could do it like that, the worry I'd have is that there would be a period where we'll be pulling a bunch of vulnerabilities back as the query will be looser and we'll be pulling the OVAL and VEX vulns. We could try and deploy everything together ( admin task and version switch) to reduce that period.

@hdonnay
Copy link
Member

hdonnay commented Sep 11, 2024

I'd rather pull "extra" results during the manual migration window than be guaranteed to produce false negatives.

@crozzy crozzy force-pushed the admin-delete-oval branch 2 times, most recently from e0d2323 to 7a91675 Compare September 11, 2024 15:32
The migration to delete OVAL vulnerabilities can take a while (10 mins
plus depending on resources). This patch adds a command to pre-delete
the vulnerabilities after adding the migration version entry.

Signed-off-by: crozzy <[email protected]>
@crozzy
Copy link
Collaborator Author

crozzy commented Sep 11, 2024

Split into 2

@crozzy
Copy link
Collaborator Author

crozzy commented Sep 13, 2024

/fast-forward

@github-actions github-actions bot merged commit d3467ba into quay:main Sep 13, 2024
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants