Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cicd: fix docker test #2032

Merged
merged 3 commits into from
Apr 12, 2024
Merged

cicd: fix docker test #2032

merged 3 commits into from
Apr 12, 2024

Conversation

hdonnay
Copy link
Member

@hdonnay hdonnay commented Apr 10, 2024

GitHub Actions is the worst CI except for every other CI service.

@hdonnay hdonnay requested a review from a team as a code owner April 10, 2024 18:12
@hdonnay hdonnay requested review from crozzy and removed request for a team April 10, 2024 18:12
@hdonnay hdonnay force-pushed the bug/nightly-ci branch 4 times, most recently from d02c8ec to 8020e1e Compare April 10, 2024 22:42
hdonnay added 2 commits April 10, 2024 18:20
Having a script in a shell argument in a script is probably not ideal.
This now writes out a script and mounts it into the container to run,
which is much easier to see what's run in which context and removes some
annoying quoting.

Signed-off-by: Hank Donnay <[email protected]>
@hdonnay
Copy link
Member Author

hdonnay commented Apr 11, 2024

Waiting for quay/claircore#1314 to be merged, then I'll double check that these changes make everything green again.

crozzy
crozzy previously approved these changes Apr 11, 2024
@hdonnay
Copy link
Member Author

hdonnay commented Apr 12, 2024

Now waiting on quay/claircore#1319 because there was another, different bug.

@hdonnay
Copy link
Member Author

hdonnay commented Apr 12, 2024

🎉 https://github.com/quay/clair/actions/runs/8664140305

@hdonnay hdonnay requested a review from crozzy April 12, 2024 15:27
@hdonnay
Copy link
Member Author

hdonnay commented Apr 12, 2024

I guess this didn't have any changes in this repo, but please push the button again

@hdonnay
Copy link
Member Author

hdonnay commented Apr 12, 2024

/fast-forward

@github-actions github-actions bot merged commit 6884969 into main Apr 12, 2024
18 checks passed
@github-actions github-actions bot deleted the bug/nightly-ci branch April 12, 2024 15:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants