Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

config: add Sentry #1895

Merged
merged 1 commit into from
Nov 14, 2023
Merged

config: add Sentry #1895

merged 1 commit into from
Nov 14, 2023

Conversation

hdonnay
Copy link
Member

@hdonnay hdonnay commented Oct 18, 2023

Depends on #1870

@hdonnay hdonnay force-pushed the hack/config/sentry branch from ff807d2 to fa5b29e Compare October 20, 2023 20:09
@hdonnay hdonnay force-pushed the hack/config/sentry branch 2 times, most recently from 287879f to 2365c6c Compare October 27, 2023 20:54
@hdonnay hdonnay marked this pull request as ready for review October 27, 2023 20:54
@hdonnay hdonnay requested a review from a team as a code owner October 27, 2023 20:54
@hdonnay hdonnay requested review from crozzy and removed request for a team October 27, 2023 20:54
@hdonnay
Copy link
Member Author

hdonnay commented Oct 27, 2023

Pretty sure these are the only parts of the Sentry SDK we want to expose directly. There's already a sampling knob, and we should be able to cook up a way to get sample-only-if-marked working.

@hdonnay hdonnay force-pushed the hack/config/sentry branch from 2365c6c to 94f10e7 Compare October 30, 2023 19:26
@hdonnay hdonnay added this to the config/v1.4.0 milestone Oct 30, 2023
@hdonnay hdonnay requested a review from crozzy November 3, 2023 20:43
Signed-off-by: Hank Donnay <[email protected]>
Copy link
Collaborator

@crozzy crozzy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@hdonnay hdonnay merged commit 3621037 into quay:main Nov 14, 2023
13 checks passed
@hdonnay hdonnay deleted the hack/config/sentry branch November 16, 2023 17:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants