Add one more check in gocriticNilValReturn #100
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cristaloleg
approved these changes
Oct 26, 2020
| @@ -191,6 +191,8 @@ func gocriticWrapperFunc(m fluent.Matcher) { | |||
| func gocriticNilValReturn(m fluent.Matcher) { | |||
| m.Match(`if $*_; $v == nil { return $v }`). | |||
There was a problem hiding this comment.
Should we drop this one? or combine them into one? @quasilyte
There was a problem hiding this comment.
I thought that this pattern catches both if statements with and without the init clause. I'll re-check this with gogrep.
There was a problem hiding this comment.
Buuuuuut we can make two rules with suggestion. Not one with some info and one with a fix.
There was a problem hiding this comment.
That's correct. But the form with the fix should go before this one.
Otherwise, the more generic pattern will match and we'll never get a suggestion.
At least it looks like we need to move the new rule above this one.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.