Output with patterns isn't expanded when patterns match long (> 60 character) identifiers.

[efarrer]

Running ruleguard -rules rules.go -fix example.go outputs "$f should be expanded to the name" but expected the output "ZeroOneTwoThreeFourFiveSixSevenEightNineTenElevenTwelveThirte should be expanded to the name" when executed with the following files.

example.go

// +build ignore

package gorules

func ZeroOneTwoThreeFourFiveSixSevenEightNineTenElevenTwelveThirte() {
}

rules.go

// +build ignore

package gorules

import "github.com/quasilyte/go-ruleguard/dsl/fluent"

func MatchesFuncsWithLongNames(m fluent.Matcher) {
        m.Match(
                `func $f($*_) { $*_ }`,
        ).
                Report(`$f should be expanded to the name`)
}

This appears to be related to the limit placed here: https://github.com/quasilyte/go-ruleguard/blob/master/ruleguard/runner.go#L191

This limit was bumped from 40 to 60 in #63

Since many engineers use long function names for unit tests (BDD) I suggest the limit be increased to at least 120 (or removed altogether). An example of a long unit test function name could be.

func TestRuleguardOutput_CorrectlyExpandsMatchingVariablesWhenMatchingLongIdentifiers(t *testing.T) {

[efarrer]

After thinking about this more perhaps a better solution would be to truncate the value instead of increasing the limit. PR for truncating the value #71

[quasilyte]

Since ruleguard is a CLI tool, it's always good to have a human-readable output that does not annoy the user.

With matcher variables, there is a risk that submatch will be huge. For example, it may occupy several source lines (100+) if you're matching the statement. Everything inside that statement will be embedded in the message. This will make a single message 1000+ characters long, which might be disappointing as it clutters the output.

The limit was a solution to filter out things that we probably don't want to interpolate. Your truncation idea is good as well, although it doesn't help with statements a lot (a more structural truncation/shortening would be better here).

[quasilyte]

I know GitHub is supposed to be almost completely a meme-free zone, but speaking of truncation...