Add sympy.Xor to json_serialization.py #6478
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maffoo
reviewed
Feb 26, 2024
| @@ -256,6 +256,7 @@ def default(self, o): | |||
| sympy.StrictLessThan, | |||
| sympy.Equality, | |||
| sympy.Unequality, | |||
| sympy.Xor, | |||
There was a problem hiding this comment.
Should we add other boolean operators as well, e.g. sympy.And, sympy.Not, sympy.Or?
There was a problem hiding this comment.
This needs to go a few other places as well: https://github.com/search?q=repo%3Aquantumlib%2FCirq+strictGreaterThan&type=code
There was a problem hiding this comment.
This all has now been done, in #6914, so this PR can be closed now.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #6478 +/- ##
=======================================
Coverage 97.75% 97.75%
=======================================
Files 1105 1105
Lines 94925 94925
=======================================
Hits 92793 92793
Misses 2132 2132 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.