Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace check/tool scripts with a direct tool invocation as feasible #6800

Open
pavoljuhas opened this issue Nov 18, 2024 · 0 comments
Open
Labels
kind/health For CI/testing/release process/refactoring/technical debt items triage/discuss Needs decision / discussion, bring these up during Cirq Cynque

Comments

@pavoljuhas
Copy link
Collaborator

Description of the issue

Some of the check/SomeTool scripts such as check/mypy or check/pylint effectively run the tool with a custom configuration file. They can be eliminated if we move tool settings to pyproject.toml and just use standard tool execution instead. This will also make it easier to run SomeTool on a specific file or with extra options as there would be no need to figure if the check/ scripts passes extra options or not.

Cirq version

1.5.0.dev at 9e21622

@pavoljuhas pavoljuhas added the kind/health For CI/testing/release process/refactoring/technical debt items label Nov 18, 2024
@NoureldinYosri NoureldinYosri added the triage/discuss Needs decision / discussion, bring these up during Cirq Cynque label Dec 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/health For CI/testing/release process/refactoring/technical debt items triage/discuss Needs decision / discussion, bring these up during Cirq Cynque
Projects
Status: No status
Development

No branches or pull requests

2 participants