Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Investigate Possible Numerical Instability in 2q and 3q analytical decompositions #6770

Open
NoureldinYosri opened this issue Oct 15, 2024 · 5 comments
Open

Investigate Possible Numerical Instability in 2q and 3q analytical decompositions #6770

NoureldinYosri opened this issue Oct 15, 2024 · 5 comments
Assignees
@RahilJain1366
Labels
kind/bug-report Something doesn't seem to work. no QC knowledge needed Want to contribute to Cirq, but don't know quantum computing? This issue is for you. triage/accepted A consensus emerged that this bug report, feature request, or other action should be worked on triage/needs-more-evidence [Feature requests] Seems plausible, but maintainers are not convinced about the use cases yet

Comments

@NoureldinYosri
Copy link
Collaborator

After adding two_qubit_matrix_to_cz_operations and three_qubit_matrix_to_operations as base cases for quantum_shannon_decomposition, some tests started to become flaky #6765. The tests pass with new versions of numpy and fail with older versions. For now I marked those tests with xfail until we are in state where we run tests with only newer numpy versions. however there might be some numerical instabilities in those methods that we may be able to fix.
@NoureldinYosri NoureldinYosri added kind/bug-report Something doesn't seem to work. triage/needs-more-evidence [Feature requests] Seems plausible, but maintainers are not convinced about the use cases yet triage/discuss Needs decision / discussion, bring these up during Cirq Cynque no QC knowledge needed Want to contribute to Cirq, but don't know quantum computing? This issue is for you. labels Oct 15, 2024
@RahilJain1366
Copy link

Hi, I would like to take this up.

@NoureldinYosri
Copy link
Collaborator Author

@RahilJain1366 thanks for offering to help. I assigned the task to you

@RahilJain1366
Copy link

Thank you @NoureldinYosri for assigning it me. I wanted to confirm my understanding. I need to replicate the two_qubit_matrix_to_cz_operations and three_qubit_matrix_to_operations on quantum_shannon_decomposition in an older version of numpy? Am I right?

@NoureldinYosri
Copy link
Collaborator Author

NoureldinYosri commented Oct 15, 2024 •
edited
Loading

this is a start ... see if you can use an old version of numpy to make the tests marked in #6767 fail ... then if you can propose a fix

@NoureldinYosri NoureldinYosri added triage/accepted A consensus emerged that this bug report, feature request, or other action should be worked on and removed triage/discuss Needs decision / discussion, bring these up during Cirq Cynque labels Oct 16, 2024
@dv8081
Copy link
Contributor

dv8081 commented Oct 16, 2024

@NoureldinYosri Could you please assign me to this issue as well?

@RahilJain1366 RahilJain1366 mentioned this issue Oct 28, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@RahilJain1366 RahilJain1366

Labels
kind/bug-report Something doesn't seem to work. no QC knowledge needed Want to contribute to Cirq, but don't know quantum computing? This issue is for you. triage/accepted A consensus emerged that this bug report, feature request, or other action should be worked on triage/needs-more-evidence [Feature requests] Seems plausible, but maintainers are not convinced about the use cases yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@NoureldinYosri @RahilJain1366 @dv8081