From 644cf2fd1ea92e67f1eaa697fbb91b6b03d5c643 Mon Sep 17 00:00:00 2001
From: Ozzie Gooen <ozzieagooen@gmail.com>
Date: Tue, 12 Nov 2024 17:05:48 -0800
Subject: [PATCH 1/2] Improved AI sidebar, form fields when invalid

---
 packages/hub/src/app/ai/Sidebar.tsx              | 16 ++++++++++------
 packages/hub/src/app/ai/api/create/route.ts      |  1 +
 .../ui/src/forms/fields/TextAreaFormField.tsx    |  4 +++-
 3 files changed, 14 insertions(+), 7 deletions(-)

diff --git a/packages/hub/src/app/ai/Sidebar.tsx b/packages/hub/src/app/ai/Sidebar.tsx
index c509b962ac..77e84f7bd9 100644
--- a/packages/hub/src/app/ai/Sidebar.tsx
+++ b/packages/hub/src/app/ai/Sidebar.tsx
@@ -1,5 +1,6 @@
 "use client";
 
+import _ from "lodash";
 import {
   forwardRef,
   useEffect,
@@ -96,21 +97,23 @@ Outputs:
 
   const handleSubmit = form.handleSubmit(
     async ({ prompt, squiggleCode, model, numericSteps, styleGuideSteps }) => {
+      const numericStepsNumber = _.toNumber(numericSteps) || 0;
+      const styleGuideStepsNumber = _.toNumber(styleGuideSteps) || 0;
       const requestBody: AiRequestBody =
         mode === "create"
           ? {
               kind: "create",
               prompt,
               model: model as LlmId,
-              numericSteps,
-              styleGuideSteps,
+              numericSteps: numericStepsNumber,
+              styleGuideSteps: styleGuideStepsNumber,
             }
           : {
               kind: "edit",
               squiggleCode,
               model: model as LlmId,
-              numericSteps,
-              styleGuideSteps,
+              numericSteps: numericStepsNumber,
+              styleGuideSteps: styleGuideStepsNumber,
             };
 
       submitWorkflow(requestBody);
@@ -163,8 +166,9 @@ Outputs:
                   name="squiggleCode"
                   label="Squiggle Code"
                   placeholder="Enter your Squiggle code here"
-                  rows={12}
-                  minRows={12}
+                  rows={8}
+                  minRows={6}
+                  maxRows={20}
                 />
               </StyledTab.Panel>
             </StyledTab.Panels>
diff --git a/packages/hub/src/app/ai/api/create/route.ts b/packages/hub/src/app/ai/api/create/route.ts
index 21f7188c1d..67a57b4d78 100644
--- a/packages/hub/src/app/ai/api/create/route.ts
+++ b/packages/hub/src/app/ai/api/create/route.ts
@@ -1,3 +1,4 @@
+import _ from "lodash";
 import { getServerSession } from "next-auth";
 
 import { LlmConfig } from "@quri/squiggle-ai";
diff --git a/packages/ui/src/forms/fields/TextAreaFormField.tsx b/packages/ui/src/forms/fields/TextAreaFormField.tsx
index 3fe380ff29..270f9877fb 100644
--- a/packages/ui/src/forms/fields/TextAreaFormField.tsx
+++ b/packages/ui/src/forms/fields/TextAreaFormField.tsx
@@ -17,9 +17,10 @@ export function TextAreaFormField<
   placeholder,
   rows,
   minRows,
+  maxRows,
   ...fieldProps
 }: CommonStringFieldProps<TValues, TName> &
-  Pick<StyledTextAreaProps, "placeholder" | "rows" | "minRows">) {
+  Pick<StyledTextAreaProps, "placeholder" | "rows" | "minRows" | "maxRows">) {
   return (
     <FormField {...fieldProps}>
       {(inputProps) => (
@@ -28,6 +29,7 @@ export function TextAreaFormField<
           placeholder={placeholder}
           rows={rows}
           minRows={minRows}
+          maxRows={maxRows}
         />
       )}
     </FormField>

From ac326ab7930a6c0fad602d69e3ec5146f916c7c1 Mon Sep 17 00:00:00 2001
From: Ozzie Gooen <ozzieagooen@gmail.com>
Date: Tue, 12 Nov 2024 17:14:54 -0800
Subject: [PATCH 2/2] Minor fix

---
 packages/hub/src/app/ai/api/create/route.ts | 1 -
 1 file changed, 1 deletion(-)

diff --git a/packages/hub/src/app/ai/api/create/route.ts b/packages/hub/src/app/ai/api/create/route.ts
index 67a57b4d78..21f7188c1d 100644
--- a/packages/hub/src/app/ai/api/create/route.ts
+++ b/packages/hub/src/app/ai/api/create/route.ts
@@ -1,4 +1,3 @@
-import _ from "lodash";
 import { getServerSession } from "next-auth";
 
 import { LlmConfig } from "@quri/squiggle-ai";