-
Notifications
You must be signed in to change notification settings - Fork 25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Relative Values: Save Model after Exporting New Variable #2361
Comments
Here's the PR! #2366.⚡ Sweep Basic Tier: I'm creating this ticket using GPT-4. You have 5 GPT-4 tickets left for the month and 3 for the day. For more GPT-4 tickets, visit our payment portal.
Actions (click)
Install Sweep Configs: Pull Request
Step 1: 🔎 SearchingI found the following snippets in your repository. I will now analyze these snippets and come up with a plan. Some code snippets I looked at (click to expand). If some file is missing from here, you can mention the path in the ticket description.squiggle/packages/website/theme.config.tsx Lines 1 to 55 in 13b14b8
squiggle/packages/hub/src/lib/common.ts Lines 1 to 12 in 13b14b8
squiggle/packages/website/src/pages/docs/Guides/Bugs.mdx Lines 1 to 43 in 13b14b8
I also found the following external resources that might be helpful:Summaries of links found in the content: Step 2: ⌨️ Coding
Modify packages/hub/src/relative-values/components/RelativeValuesDefinitionForm/index.tsx with contents:
Modify packages/hub/src/relative-values/components/RelativeValuesDefinitionForm/index.tsx with contents: In the `RelativeValuesDefinitionForm` component, we need to define the `exportData` function. This function should take the form data as an argument and return the data in the required format for the `save` function. The exact implementation of this function will depend on the specific requirements of the `save` function and the format of the form data. If the `save` function expects the data in the same format as the form data, the `exportData` function can simply return the data as is. If the `save` function expects the data in a different format, the `exportData` function should transform the form data into the required format.
Step 3: 🔁 Code ReviewHere are my self-reviews of my changes at Here is the 1st review Thanks for your work on this. There are a couple of things we need to address: I finished incorporating these changes. 🎉 Latest improvements to Sweep:
💡 To recreate the pull request edit the issue title or description. To tweak the pull request, leave a comment on the pull request. |
Description of suggestion or shortcoming:
Right now, to make a new export, you need to:
We should instead "save".
Checklist
packages/hub/src/relative-values/components/RelativeValuesDefinitionForm/index.tsx
✓ e2d64edpackages/hub/src/relative-values/components/RelativeValuesDefinitionForm/index.tsx
✗packages/hub/src/relative-values/components/RelativeValuesDefinitionForm/index.tsx
✓ a7f9932packages/hub/src/relative-values/components/RelativeValuesDefinitionForm/index.tsx
✗packages/hub/src/relative-values/components/RelativeValuesDefinitionForm/index.tsx
✗The text was updated successfully, but these errors were encountered: