Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[12.0][4269][IMP] stock_outgoing_shipment_report: use fields from picking instead… #104

Merged
merged 3 commits into from
Mar 2, 2024

Conversation

AungKoKoLin1997
Copy link
Contributor

@codecov-commenter
Copy link

codecov-commenter commented Feb 9, 2024

Codecov Report

Attention: 24 lines in your changes are missing coverage. Please review.

Comparison is base (79beb6a) 72.83% compared to head (642c416) 72.46%.

Files Patch % Lines
...going_shipment_report/models/carrier_info_mixin.py 52.94% 8 Missing ⚠️
...tock_outgoing_shipment_report/models/sale_order.py 60.00% 7 Missing and 1 partial ⚠️
...k_outgoing_shipment_report/models/stock_picking.py 33.33% 8 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##             12.0     #104      +/-   ##
==========================================
- Coverage   72.83%   72.46%   -0.37%     
==========================================
  Files          88       89       +1     
  Lines         703      730      +27     
  Branches      131      132       +1     
==========================================
+ Hits          512      529      +17     
- Misses        181      191      +10     
  Partials       10       10              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@AungKoKoLin1997 AungKoKoLin1997 marked this pull request as ready for review February 9, 2024 06:45
Copy link
Member

@yostashiro yostashiro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@AungKoKoLin1997 Please review the commit I added.

@yostashiro yostashiro force-pushed the 12.0-imp-stock_outgoing_shipment_report branch from 746d3d4 to 5aefb2f Compare February 9, 2024 16:42
@yostashiro yostashiro merged commit a20bb2c into 12.0 Mar 2, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants