[12.0][3697][ADD] product_standard_price_restriction #103
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AungKoKoLin1997
requested review from
yostashiro,
kanda999,
rinaldifirdaus and
liuhehe1995
Codecov Report
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. @@ Coverage Diff @@
## 12.0 #103 +/- ##
==========================================
+ Coverage 72.64% 72.83% +0.18%
==========================================
Files 84 88 +4
Lines 680 703 +23
Branches 126 131 +5
==========================================
+ Hits 494 512 +18
- Misses 176 181 +5
Partials 10 10
|
yostashiro
reviewed
Oct 17, 2023
| @@ -0,0 +1,41 @@ | |||
|
|
|||
| @@ -0,0 +1,7 @@ | |||
| <?xml version="1.0" encoding="utf-8" ?> | |||
| <odoo> | |||
| <record id="group_product_manager" model="res.groups"> | |||
There was a problem hiding this comment.
@rinaldifirdaus Do you think we should add this group this time, according to the requirement discussed with the client?
There was a problem hiding this comment.
@rinaldifirdaus Please add the business background.
yostashiro
reviewed
Oct 23, 2023
| raise UserError( | ||
| _( | ||
| "You are about to update the cost. This field is " | ||
| "auto-calculated by Odoo and is an 'Weighted Average Value' of " |
There was a problem hiding this comment.
It is not good to hardcode a message like this. Can we make the message more generic, or put it in a configuration field (upon adding a field perhaps in res.company)?
AungKoKoLin1997
force-pushed
the
3697-add-product_standard_price_restriction
branch
from
42381b6
to
4dc2d64
Compare
AungKoKoLin1997
force-pushed
the
3697-add-product_standard_price_restriction
branch
from
4dc2d64
to
b464a18
Compare
rinaldifirdaus
approved these changes
Oct 27, 2023
yostashiro
approved these changes
Oct 27, 2023
| _inherit = "product.template" | ||
|
|
||
| standard_price = fields.Float(track_visibility='onchange') | ||
| update_cost = fields.Boolean() |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
3697