You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
As things are right now, our Result objects are fairly limited in their usefulness.
The only thing which they are capable of is being formatted as strings to be printed. But also here we have been running into problems. For example our ElectronicStructureResult forcefully requires ParticleNumber, AngularMomentum and Magnetization values to be computed. If either of them is missing, printing of the object will fail.
This needs to be fixed and some other improvements I have in mind are the following:
refactor them as dataclasses (automatically makes them a lot more useful since they can be converted to and from dictionaries)
add storing/loading capabilities (with the above, json will be almost trivially supported)
What should we add?
As things are right now, our
Result
objects are fairly limited in their usefulness.The only thing which they are capable of is being formatted as strings to be printed. But also here we have been running into problems. For example our
ElectronicStructureResult
forcefully requiresParticleNumber
,AngularMomentum
andMagnetization
values to be computed. If either of them is missing, printing of the object will fail.This needs to be fixed and some other improvements I have in mind are the following:
dataclasses
(automatically makes them a lot more useful since they can be converted to and from dictionaries)json
will be almost trivially supported)qiskit-nature/qiskit_nature/second_q/problems/electronic_structure_result.py
Lines 99 to 100 in bf3ce82
The text was updated successfully, but these errors were encountered: