Remove webhook server #73
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
qinqon
force-pushed
the
remove-webhook-server
branch
4 times, most recently
from
652ec03
to
d60d94c
Compare
Now that controller-runtime is able to configure CipherSuites we no longer need the webhook server. This change remove the custom server but keeps the pair of functions to map tls versions and cipher suites, it also bumps controller-runtime to 0.13.1 wich is the minimal that allow configuring cipher suites. Signed-off-by: Enrique Llorente <[email protected]>
qinqon
force-pushed
the
remove-webhook-server
branch
from
d60d94c
to
8be4d83
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now that controller-runtime is able to configure CipherSuites we no longer need the webhook server. This change remove the custom server but keeps the pair of functions to map tls versions and cipher suites, it also bumps controller-runtime to 0.13.1 wich is the minimal that allow configuring cipher suites.