Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: make GitCommitDate as optional #14

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

feat: make GitCommitDate as optional #14

wants to merge 1 commit into from

Conversation

e06084
Copy link
Collaborator

@e06084 e06084 commented Jan 13, 2023

No description provided.

xen0n
xen0n reviewed Jan 13, 2023
View reviewed changes
Copy link
Collaborator

@xen0n xen0n left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please consider making a similar change for the v2 branch as well. Arguably people and go get should be preferring v2 for a while.

.gitignore

# idea
.idea/
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please make the gitignore change a separate commit, and make sure the last line is terminated with a \n.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xen0n xen0n xen0n left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@e06084 @xen0n