Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ENH: make group-column optional in pairwise-distances #114

Open
nbokulich opened this issue Aug 13, 2018 · 1 comment
Open

ENH: make group-column optional in pairwise-distances #114

nbokulich opened this issue Aug 13, 2018 · 1 comment
Labels
diff:1|beginner Only limited knowledge of the languages and platform is required. good first issue Good for newcomers Hacktoberfest Good fit for the Hacktoberfest challenge help wanted Extra attention is needed lang:python Python 3 low-priority scope:0|this-project No other repositories are impacted. src:forum From the QIIME 2 Forum. time:1|short Should not take very much time to complete (assuming familiarity). type:improvement Making something better. weight:0|someday It's a good idea, but no schedule on delivery.

Comments

@nbokulich
Copy link
Member

Improvement Description
Make group-column optional. Then paired distances would be plotted for all samples. No stats would be calculated.

Current Behavior
group-column is required, so some comparison must be made. See example viz

Proposed Behavior
Make group-column optional, so that paired distances for all samples can be plotted together.

References
forum x-ref
@nbokulich nbokulich added help wanted Extra attention is needed low-priority diff:1|beginner Only limited knowledge of the languages and platform is required. good first issue Good for newcomers lang:python Python 3 scope:0|this-project No other repositories are impacted. src:forum From the QIIME 2 Forum. time:1|short Should not take very much time to complete (assuming familiarity). type:improvement Making something better. weight:0|someday It's a good idea, but no schedule on delivery. labels Aug 13, 2018
@ebolyen ebolyen added the Hacktoberfest Good fit for the Hacktoberfest challenge label Oct 10, 2018
@gregcaporaso
Copy link
Member

I just ran into a need for this, so I'll take a crack at a fix.

I feel like there is probably a way to do the stats too, even if there is only one group - e.g., by shuffling the pre-post pairings 1000 times and comparing the median of the actual pre-post data to the distributions of the medians of the 1000 shuffled pairings, but I have to think about that a bit. Anyone have ideas there?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
diff:1|beginner Only limited knowledge of the languages and platform is required. good first issue Good for newcomers Hacktoberfest Good fit for the Hacktoberfest challenge help wanted Extra attention is needed lang:python Python 3 low-priority scope:0|this-project No other repositories are impacted. src:forum From the QIIME 2 Forum. time:1|short Should not take very much time to complete (assuming familiarity). type:improvement Making something better. weight:0|someday It's a good idea, but no schedule on delivery.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@gregcaporaso @nbokulich @ebolyen