Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

extract zip and add contents #8

Open
pvgenuchten opened this issue Oct 16, 2020 · 1 comment
Open

extract zip and add contents #8

pvgenuchten opened this issue Oct 16, 2020 · 1 comment

Comments

@pvgenuchten
Copy link

hi, i couldn't get the plugin to work before, but on 3.14 it worked out of the box, great work!

in netherlands we have a lot of zipped resources attached to atom files

would be nice if the plugin would extract the zip file and adds the content (shapefiles in most cases) to the qgis map

example service is: https://geodata.nationaalgeoregister.nl/atom/index.xml

@ejn
Copy link
Contributor

ejn commented Oct 19, 2020

Hi, it "should just work" (TM) with zipfiles already - I just tested again with https://www.geodaten-mv.de/dienste/dvg_atom (which actually just provides links to GetFeature-requests with outputformat set to SHAPEZIP) and QGIS successfully added the layer.

I also tested with your link and the (randomly selected) dataset "Nationale Parken" (I could guess what data that is, and the download was not too big!) and it worked fine.

On the other hand I tried it with "CBS - Wijken en Buurten 2016" and it didn't work.

So far as I can see, the difference is that the CBS dataset is

  1. in a subfolder and not in the root folder of the zip archive, and
  2. is composed of multiple shapefiles.

Point 2 was raised in Issue 3 and should have been dealt with by 687655f - although obviously not sufficiently.

I would be very happy to accept a PR to deal with this if you're able to supply one - otherwise I will try and look at it as time allows. The enhancement is no doubt necessary in inspireatomclientdialog->load_downloaded_files.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants