Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Handle weight and percentage both being specified #17

Open
wvengen opened this issue Nov 12, 2019 · 1 comment
Open

Handle weight and percentage both being specified #17

wvengen opened this issue Nov 12, 2019 · 1 comment
Labels
bug:parsing Something is not parsed or parsed incorrectly

Comments

@wvengen
Copy link
Member

wvengen commented Nov 12, 2019

Sometimes both a percentage and a weight is specified, maybe we need to support both:

Double chocolate cookiemix 400 g (89,9%): TARWEbloem [GLUTEN], suiker, palmolie, zonnebloemolie, glucosestroop, magere cacaopoeder 7,2%, KIPHEELEIpoeder (scharrel), MELKeiwit, GERSTemoutbloem [GLUTEN], zout, rijsmiddelen: E500-E450, aroma. Witte chocolade chunks 45 g (10,1%): suiker, volle MELKpoeder, cacaoboter, emulgator: SOJAlecithine, aroma.
@wvengen wvengen added the bug:parsing Something is not parsed or parsed incorrectly label Nov 12, 2019
@wvengen
Copy link
Member Author

wvengen commented Dec 28, 2020 •
edited
Loading

We could recognize both percentage and amount, where a new attribute 'percentage' contains the percentage, and the existing attribute 'amount' is about weight or volume (breaking change, though). I haven't seen both weight and volume specified, so this should be ok.

@wvengen wvengen changed the title Handle multiple amounts Handle weight and percentage both being specified Dec 28, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug:parsing Something is not parsed or parsed incorrectly
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@wvengen