Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Always invoke gradle wrapper, or not. #37

Closed
amotl opened this issue Dec 2, 2023 · 1 comment
Closed

Always invoke gradle wrapper, or not. #37

amotl opened this issue Dec 2, 2023 · 1 comment

Comments

@amotl
Copy link
Member

amotl commented Dec 2, 2023

Introduction

In order to support projects not including a Gradle wrapper, invoking gradle wrapper was sufficient to create one.
However, this leads to problems on other projects which include a wrapper already, so we removed invoking this command per GH-27.

Problem

Now, we are seeing here, that it indeed leads to problems on projects which would like to generate a new wrapper, because, well, they are running on a newer version of Java where the shipped Gradle wrapper is not compatible with.

The effect is this error message:

BUG! exception in phase 'semantic analysis' in source unit '_BuildScript_' Unsupported class file major version 65

Thoughts

If we are reverting that change, we could push into a similar direction: Just wipe gradlew and invoke gradle wrapper to generate a new one, which will match the designated Java version. Is it a reasonable idea?

@amotl
Copy link
Member Author

amotl commented Dec 3, 2023

This proposal was implemented with GH-38, and validated on behalf of another CI run on two real-world Java projects.

/cc @matriv, @seut, @surister, @pilosus

@amotl amotl closed this as completed Dec 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant