Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Does pyorbital no longer calculate moon phase? #48

Open
conkline opened this issue Oct 16, 2019 · 7 comments · May be fixed by #96
Open

Does pyorbital no longer calculate moon phase? #48

conkline opened this issue Oct 16, 2019 · 7 comments · May be fixed by #96
Assignees
Labels

Comments

@conkline
Copy link

Iʻm looking for a quick and simple way to calculate moon phase on a given date, and wanted to follow this tutorial:
https://pyorbital.readthedocs.io/en/feature-moon-phase/moon_calculations.html

I installed pyorbital successfully, but get a <AttributeError: module 'pyorbital' has no attribute 'moon_phase'> error. Looking through the code, I was unable to find this module, unless Iʻm missing something.

Is moon_phase no longer an included module?

@mraspaud
Copy link
Member

@adybbroe Any insight ?

@djhoese
Copy link
Member

djhoese commented Oct 16, 2019

Is it in this branch and never got merged? https://github.com/pytroll/pyorbital/tree/feature-moon-phase

@conkline
Copy link
Author

Ah, looks like it! Thank you!

@advaiyalad
Copy link

Is it possible for this branch to be merged? The work in it seems to work well.

@djhoese djhoese linked a pull request Mar 23, 2022 that will close this issue
5 tasks
@djhoese
Copy link
Member

djhoese commented Mar 23, 2022

I create #96 from this branch, but it will take a lot of work to get it ready for merging. If anyone (@adybbroe @PythonCreator27 @conkline ) are interested in tackling this challenge, let us know here.

@Lebostein
Copy link

Same problem here. I found this official doc of pyorbital, but the code don't work: "ModuleNotFoundError: No module named 'pyorbital.moon_phase'". And then I found this request here. It still doesn't seem to be working...

@pnuu
Copy link
Member

pnuu commented Oct 25, 2024

The "official documentation" is the documentation built for the old pull request linked above. The latest version of Pyorbital does not have this feature, see the documentation at https://pyorbital.readthedocs.io/en/latest/

If anyone is willing to work on bringing the old PR up-to-date, please have a look at #96

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

7 participants