From 1a1b80d039be5fafc40dd0024e28c62f4cae8c47 Mon Sep 17 00:00:00 2001 From: Frederik Gossen Date: Mon, 11 Dec 2023 15:51:25 -0500 Subject: [PATCH] Revert "Allow benchmark runner config: `openxla` for inference runs. (#5939)" This reverts commit dcdd66e387a2d8ee1ca3352ccca1b53e54a98354. --- benchmarks/README.md | 3 +-- benchmarks/benchmark_experiment.py | 3 ++- benchmarks/experiment_runner.py | 2 +- 3 files changed, 4 insertions(+), 4 deletions(-) diff --git a/benchmarks/README.md b/benchmarks/README.md index 21432f06522..a93b8f3bb14 100644 --- a/benchmarks/README.md +++ b/benchmarks/README.md @@ -66,10 +66,9 @@ python xla/benchmarks/experiment_runner.py \ You can change the flags to add the configurations you are interested in. The `experiment_runner.py` will expand the options to all supported configurations. For example, in the case above, it will consider all the possible combinations -among the flags `--dynamo`, `--xla`, and `--test`, 5 of which are supported: +among the flags `--dynamo`, `--xla`, and `--test`, 4 of which are supported: - `dynamo=openxla_eval`, `xla=PJRT`, `test=eval` - - `dynamo=openxla`, `xla=PJRT`, `test=eval` - `dynamo=openxla`, `xla=PJRT`, `test=train` - `dynamo=inductor`, `xla=None`, `test=eval` - `dynamo=inductor`, `xla=None`, `test=train` diff --git a/benchmarks/benchmark_experiment.py b/benchmarks/benchmark_experiment.py index c2c2d8f88f5..977146c3813 100644 --- a/benchmarks/benchmark_experiment.py +++ b/benchmarks/benchmark_experiment.py @@ -88,7 +88,8 @@ def is_available(self, experiment_config): if experiment_config["dynamo"] == "openxla_eval" and not ( experiment_config["xla"] and experiment_config["test"] == "eval"): return False - if experiment_config["dynamo"] == "openxla" and not experiment_config["xla"]: + if experiment_config["dynamo"] == "openxla" and not ( + experiment_config["xla"] and experiment_config["test"] == "train"): return False if (experiment_config["xla"] and not is_xla_device_available(experiment_config["accelerator"].upper())): diff --git a/benchmarks/experiment_runner.py b/benchmarks/experiment_runner.py index 124eebed0bd..18f26f1d22e 100644 --- a/benchmarks/experiment_runner.py +++ b/benchmarks/experiment_runner.py @@ -531,7 +531,7 @@ def parse_args(args=None): "--collect-full-output", action="store_true", help="""Whether to collect full output for training. Set this to true if we - want to verify the numerical correctness of gradients. But that may + want to verify the numerical correctness of graidents. But that may cause time measurement not accurate""", )