-
Notifications
You must be signed in to change notification settings - Fork 487
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
GPU CI should fail on hanging tests. #6385
Comments
Was able to reproduce the issue in the pr #6383 as well as running locally a bash script
If you see the output, you can see that the exit code is 0 (success). |
The issue happens in
where everything runs in the According to https://bugs.python.org/issue27035, python 2 can set the correct exit code (expect to be non-zero) if an exception is raised in the |
Even if I make the atexit callback to raise an SystemExit exception such as
, the exit status is still 0. See output |
With the change in the PR #6383, the GPU CI fails as expected |
🐛 Bug
In #6247, we found that when tests hang the GPU CI still showed green. This is unexpected.
To Reproduce
Apply the change in #6247, we should be able to see that the GPU CI passes but there is error message in the GPU CI log and the tests hang when running locally.
Expected behavior
When tests hang, GPU CI should fail.
Environment
Additional context
The text was updated successfully, but these errors were encountered: