From 343f66939a3381c3377fe5f00b789f913e8b4e54 Mon Sep 17 00:00:00 2001 From: Siyuan Liu Date: Mon, 9 Oct 2023 17:10:00 +0000 Subject: [PATCH] re-enable ECR push --- .github/workflows/_build.yml | 24 ++++++++++++------------ 1 file changed, 12 insertions(+), 12 deletions(-) diff --git a/.github/workflows/_build.yml b/.github/workflows/_build.yml index 9b7f47772d47..18e1904458fb 100644 --- a/.github/workflows/_build.yml +++ b/.github/workflows/_build.yml @@ -7,7 +7,7 @@ on: type: string description: Base image for builds ecr-docker-image-base: - required: false + required: true type: string description: Container registry to upload image to runner: @@ -64,17 +64,17 @@ jobs: - name: Download docker image from GCR shell: bash run: docker pull "${GCR_DOCKER_IMAGE}" - # - name: Stage image to ECR - # shell: bash - # run: | - # # This is to stage PyTorch/XLA base image for use in the upstream. - # # To allow the upstream workflow to access PyTorch/XLA build images, we - # # need to have them in the ECR. This is not expensive, and only pushes it - # # if image layers are not present in the repo. - # # Note: disable the following 2 lines while testing a new image, so we do not - # # push to the upstream. - # docker tag "${GCR_DOCKER_IMAGE}" "${ECR_DOCKER_IMAGE_BASE}:v1.1.1-lite-test" >/dev/null - # docker push "${ECR_DOCKER_IMAGE_BASE}:v1.1.1-lite-test" >/dev/null + - name: Stage image to ECR + shell: bash + run: | + # This is to stage PyTorch/XLA base image for use in the upstream. + # To allow the upstream workflow to access PyTorch/XLA build images, we + # need to have them in the ECR. This is not expensive, and only pushes it + # if image layers are not present in the repo. + # Note: disable the following 2 lines while testing a new image, so we do not + # push to the upstream. + docker tag "${GCR_DOCKER_IMAGE}" "${ECR_DOCKER_IMAGE_BASE}:v1.1.2-lite-test" >/dev/null + docker push "${ECR_DOCKER_IMAGE_BASE}:v1.1.2-lite-test" >/dev/null - name: Start the container shell: bash run: |