Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build notification bot to notify the commit author if their change is breaking trunk #5828

Open
huydhn opened this issue Oct 26, 2024 · 0 comments

Comments

@huydhn
Copy link
Contributor

huydhn commented Oct 26, 2024

This is an action item coming out of https://fburl.com/gdoc/oppetklz. When a commit break trunk, we want to have a bot to notify the commit author about the issue, for example, commenting on the pull request and cc the author.

Notes to bootcampers:

  • A ClickHouse query is likely needed to decided if a failure is breaking trunk or just flaky. A broken trunk failure is defined as failing in trunk N consecutive times
    • torchci/clickhouse_queries/flaky_workflows_jobs/query.sql is an example on how to flaky failures
  • Ask me or @clee2000 to grant you access to https://clickhouse.com
  • PyTorch bot code is at https://github.com/pytorch/test-infra/tree/main/torchci/lib/bot
  • Bonus point is to be able to submit a reverted PR to gather its signals
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Cold Storage
Development

No branches or pull requests

1 participant