Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adding graviton docker image release #3313

Merged
merged 38 commits into from
Sep 17, 2024
Merged

adding graviton docker image release #3313

merged 38 commits into from
Sep 17, 2024

Conversation

udaij12
Copy link
Collaborator

@udaij12 udaij12 commented Sep 12, 2024

Description

adding cpu graviton image docker to docker (nightly and official release) using docker multibuild.

For kserve nightly and official release.

Tested in this run: https://github.com/pytorch/serve/actions/runs/10868922493
result: https://hub.docker.com/repository/docker/udaij12/torchserve-nightly/tags

@udaij12 udaij12 marked this pull request as ready for review September 12, 2024 22:27
.github/workflows/docker-nightly-build.yml Outdated Show resolved Hide resolved
docker/build_image.sh Outdated Show resolved Hide resolved
docker/docker_nightly.py Outdated Show resolved Hide resolved
docker/docker_nightly.py Show resolved Hide resolved
docker/docker_nightly.py Show resolved Hide resolved
Copy link
Collaborator

@agunapal agunapal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Can you please also update the official release script and kserve too

Copy link
Collaborator

@agunapal agunapal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please update this too https://github.com/pytorch/serve/blob/master/kubernetes/kserve/docker_nightly.py

and please update the PR title/description to indicate what its covering

@udaij12 udaij12 changed the title adding graviton docker image adding graviton docker image release Sep 16, 2024
Copy link
Collaborator

@agunapal agunapal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Lets track if the nightly images are uploaded correctly

@udaij12 udaij12 added this pull request to the merge queue Sep 17, 2024
Merged via the queue into master with commit ba8c268 Sep 17, 2024
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants