CI: Add Security Check Using Bandit in CI #3312
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mreso
requested changes
Sep 12, 2024
| print("Could not generate gRPC client stubs") | ||
| sys.exit(1) | ||
|
|
||
| cmd = "python -m pytest -v ./ --ignore=sanity" | ||
| pytest_cmd = ["python", "-m", "pytest", "-v", "./", "--ignore=sanity"] |
There was a problem hiding this comment.
This command is not running in REPO_ROOT/test/pytest/ which might break some tests. Not 100% sure if all of of them are resilient to that.
There was a problem hiding this comment.
Yes, but I haven’t changed the execution logic. So, if it worked before, it should be fine now.
ChengyuZhu6
force-pushed
the
secure-check
branch
3 times, most recently
from
c1d296d
to
47a194a
Compare
Thanks for your review @mreso. I have addressed all your comments. PTAL thanks. |
ChengyuZhu6
force-pushed
the
secure-check
branch
from
47a194a
to
187ed53
Compare
|
Just rebased to pick up the latest changes. |
|
kindly ping @mreso |
- Integrate Bandit to scan for security issues in the codebase. - Configure Bandit to fail the workflow if any high-severity issues are found. e.g.: ```bash >> Issue: [B605:start_process_with_a_shell] Starting a process with a shell, possible injection detected, security issue. Severity: High Confidence: High CWE: CWE-78 (https://cwe.mitre.org/data/definitions/78.html) More Info: https://bandit.readthedocs.io/en/1.7.9/plugins/b605_start_process_with_a_shell.html Location: ./binaries/build.py:52:30 51 if not args.dry_run: 52 build_exit_code = os.system(cur_wheel_cmd) 53 # If any one of the steps fail, exit with error ``` Fixes: pytorch#3311 Signed-off-by: ChengyuZhu6 <[email protected]>
…=True - Issue: Fixed [B602:subprocess_popen_with_shell_equals_true] identified by Bandit, which flagged the use of `subprocess.Popen` with `shell=True` as a high-severity security risk (CWE-78: OS Command Injection). - Ensures that the command is executed more securely without exposing it to shell injection vulnerabilities. Signed-off-by: ChengyuZhu6 <[email protected]>
…hell - Issue: Fixed [B605:start_process_with_a_shell] identified by Bandit, which flagged starting a process with a shell as a high-severity security risk (CWE-78: OS Command Injection). - Replaced os.system call with a safer alternative to prevent shell injection vulnerabilities. Signed-off-by: ChengyuZhu6 <[email protected]>
ChengyuZhu6
force-pushed
the
secure-check
branch
from
3f88489
to
a7e7d6e
Compare
|
Just rebased to pick up the latest changes. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Currently, the project does not have a security linter integrated into its CI pipeline. This poses potential risks as security vulnerabilities in Python code can go undetected. I found many high security issues using Bandit
error log: https://github.com/user-attachments/files/16975951/security-issues.log
Resolve two high security issues:
Fixes #3311
Type of change
Feature/Issue validation/testing