Support -debug-glow-only even in release builds

Reviewed By: junhanh Differential Revision: D54523800 fbshipit-source-id: d267fd4466afea2bd24f1b1cf97f4c22099cced4
pytorch · Mar 5, 2024 · 0c03ae9 · 0c03ae9
1 parent 9ecc93a
commit 0c03ae9
Show file tree

Hide file tree

Showing 3 changed files with 5 additions and 7 deletions.
diff --git a/include/glow/Support/Debug.h b/include/glow/Support/Debug.h
@@ -18,15 +18,15 @@
 
 namespace glow {
 
-#ifndef NDEBUG
+#if !defined(NDEBUG) && !defined(DISABLE_DEBUG_GLOW)
 
 /// \returns true if \p type matches the activated debug type.
-bool isCurrentDebugType(const char *type);
+bool isGlowCurrentDebugType(const char *type);
 
 /// Macro to perform debug actions when TYPE is activated.
 #define DEBUG_GLOW_WITH_TYPE(TYPE, X)                                          \
   do {                                                                         \
-    if (glow::DebugFlag || glow::isCurrentDebugType(TYPE)) {                   \
+    if (glow::DebugFlag || glow::isGlowCurrentDebugType(TYPE)) {               \
       X;                                                                       \
     }                                                                          \
   } while (false)

diff --git a/lib/Optimizer/IROptimizer/IROptimizer.cpp b/lib/Optimizer/IROptimizer/IROptimizer.cpp
@@ -160,12 +160,10 @@ class LiveIntervalsInstructionNumbering {
 };
 } // namespace
 
-#ifndef NDEBUG
 llvm::raw_ostream &operator<<(llvm::raw_ostream &os, const Interval &I) {
   os << I.str();
   return os;
 }
-#endif
 
 /// Set of intervals for a single memory buffer. If there is only one write into
 /// a memory buffer, it would contain a single interval. If there are multiple

diff --git a/lib/Support/Debug.cpp b/lib/Support/Debug.cpp
@@ -41,8 +41,8 @@ namespace glow {
 /// Exported boolean set by -debug-glow option.
 bool DebugFlag = false;
 
-#ifndef NDEBUG
-bool isCurrentDebugType(const char *type) {
+#if !defined(NDEBUG) && !defined(DISABLE_DEBUG_GLOW)
+bool isGlowCurrentDebugType(const char *type) {
   return std::find(DebugGlowOnly.begin(), DebugGlowOnly.end(), type) !=
          DebugGlowOnly.end();
 }