Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Selected proposals are not ordered #675

Open
ananyo2012 opened this issue May 2, 2020 · 0 comments · May be fixed by #679
Open

Selected proposals are not ordered #675

ananyo2012 opened this issue May 2, 2020 · 0 comments · May be fixed by #679
Labels
has-pr type/bug

Comments

@ananyo2012
Copy link
Contributor

The list of selected proposals are not ordered in the proposals listing page. Check https://in.pycon.org/cfp/2018/proposals/ . The list of selected Talks and Workshops are not in order. While the public proposals listing doesn't seem to have an issue.

This seems to be caused due to missing order_by filter in the proposal view.

junction/junction/proposals/views.py

Lines 104 to 106 in a9bd537

selected_proposals_list = proposals_qs.filter(
review_status=ProposalReviewStatus.SELECTED
)

ananyo2012 added a commit that referenced this issue May 24, 2020
@ananyo2012
Order selected proposals on created_at timestamp
8785e1c 
Order proposals sections and proposal types on modified_at timestamp

Fixes #675, #678
@ananyo2012 ananyo2012 linked a pull request May 24, 2020 that will close this issue
Open
@ananyo2012 ananyo2012 mentioned this issue Oct 17, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
has-pr type/bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Ordering fixes pythonindia/junction
1 participant
@ananyo2012