Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Turn off PGO for JIT CI #127154

Closed
brandtbucher opened this issue Nov 22, 2024 · 1 comment · Fixed by #127212
Closed

Turn off PGO for JIT CI #127154

brandtbucher opened this issue Nov 22, 2024 · 1 comment · Fixed by #127212
Assignees
@savannahostrowski
Labels
3.14 new features, bugs and security fixes infra CI, GitHub Actions, buildbots, Dependabot, etc. topic-JIT

Comments

@brandtbucher
Copy link
Member

brandtbucher commented Nov 22, 2024 •
edited by bedevere-app bot
Loading

I don't think we need PGO turned on in JIT CI for non-debug jobs. It's mostly just a waste of time, and doesn't really give us any additional information.

@mdboom, I know that the Windows PGO builds were a nice canary for "breaking" ceval.c under MSVC (since it's not tested in CI or any buildbot), but I figure our weekly benchmarking runs are a good enough "buildbot" for that, so we don't need to run it all the time on PRs.

@savannahostrowski, want to take this?

Linked PRs
@brandtbucher brandtbucher added 3.14 new features, bugs and security fixes topic-JIT infra CI, GitHub Actions, buildbots, Dependabot, etc. labels Nov 22, 2024
@savannahostrowski savannahostrowski self-assigned this Nov 22, 2024
@mdboom
Copy link
Contributor

mdboom commented Nov 22, 2024 •
edited
Loading

Yeah, I agree that PGO+JIT together doesn't add much value.

Historically, I don't think our benchmarking stuff has been a soon-enough canary for MSVC, so I'd still like to see a buildbot specifically test that configuration. I think I'll file a separate bug for that -- python/buildmaster-config#560 -- no need for that to hold this up.

@bedevere-app bedevere-app bot mentioned this issue Nov 24, 2024
Merged
@savannahostrowski savannahostrowski linked a pull request Nov 24, 2024 that will close this issue
GH-127154: Remove PGO from JIT CI #127212
Merged
savannahostrowski added a commit to savannahostrowski/cpython that referenced this issue Nov 24, 2024
@savannahostrowski
Merge branch 'main' into pythongh-127154
da8bdb8
savannahostrowski added a commit that referenced this issue Nov 27, 2024
@savannahostrowski
GH-127154: Remove PGO and unknown-linux-gnu/clang from JIT CI (#127212)
2247dd0
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@savannahostrowski savannahostrowski

Labels
3.14 new features, bugs and security fixes infra CI, GitHub Actions, buildbots, Dependabot, etc. topic-JIT
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

GH-127154: Remove PGO from JIT CI savannahostrowski/cpython
3 participants
@mdboom @savannahostrowski @brandtbucher