-
Notifications
You must be signed in to change notification settings - Fork 335
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support configurable OAUTH redirect URLs #438
Comments
Ran into this exact same problem today, hope to see a fix. |
Just raised the PR for the branch with my change in the hope that it gets noticed. |
Hi @j5awry are you able to give any feedback on this issue, or review the linked PR? Thanks. |
HI @ziirish are you take a review on the PR or point me in the direction of someone else who can? thanks |
@peter-doggart are you able to review this? |
@thedumbterminal This is on my to-do list. Just haven't had a chance to do any updates lately, but I will make sure this makes it into the next release. |
Thanks 🙏 |
Is your feature request related to a problem? Please describe.
Currently when using oauth the redirect URL is hardcoded here:
https://github.com/python-restx/flask-restx/blob/master/flask_restx/templates/swagger-ui.html#L55
The included
oauth2-redirect.html
is fine unless you are implementing OAUTH on the server side where you need logic such as creating a user account etc.Describe the solution you'd like
I'd like to set my own OAUTH redirect URL so after the OAUTH dance I can create user accounts, for example using
flask-security
. This could be done via an flask app config setting.Describe alternatives you've considered
Did briefly consider how to redirect the default swagger redirect URL, but it seems wrong to use it for anything other than documentation needs.
Additional context
Example of using flask-dance for oauth to allow specific OAUTH handlers:
https://github.com/singingwolfboy/flask-dance-github
I've got a working branch here, which I can submit a PR for if the feature is accepted:
https://github.com/python-restx/flask-restx/compare/master...thedumbterminal:oauth-redirect?expand=1
The text was updated successfully, but these errors were encountered: