Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PEP 621 support: fix merging project.optional-dependencies with tool.poetry.dependencies #792

Merged

Conversation

radoering
Copy link
Member

The extra marker of optional dependencies (of the root project) is usually only implicit but has to be considered when merging dependencies.

  • Added tests for changed code.
  • Updated documentation for changed code.

@radoering radoering requested a review from a team November 23, 2024 13:30
@radoering radoering added the 2.0 PRs for core 2.0 label Nov 24, 2024
…poetry.dependencies

The extra marker of optional dependencies is usually only implicit but has to be considered when merging dependencies.
@abn abn force-pushed the fix-dependency-merge-by-extra-marker branch from fc7b524 to a336fdf Compare November 25, 2024 13:10
@abn abn enabled auto-merge (rebase) November 25, 2024 13:11
@abn abn merged commit 29db619 into python-poetry:main Nov 25, 2024
21 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
2.0 PRs for core 2.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants