Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Only get manually added certificates #5

Open
mhils opened this issue Jan 5, 2016 · 1 comment
Open

Only get manually added certificates #5

mhils opened this issue Jan 5, 2016 · 1 comment

Comments

@mhils
Copy link
Member

mhils commented Jan 5, 2016

It would be great to get the subset of certificates which have been manually added by the user. This would allow to ship software that does public key pinning but still works with corporate TLS appliances, mitmproxy or similar software.

@Lukasa
Copy link
Member

Lukasa commented Jan 6, 2016

+1 agreed. I will talk to the Google Chrome folks to see if I can work out how they handle this on their end, but we should work out what the API looks like.

The issue here is that, in almost all cases, what we want to do is to provide the full set of CAs in the bundle, but then have the HPKP implementation check whether the root cert is in the trust store. This means we need to do comparison of X509 certs. I suppose we could just check whether the DER-encoded bytes of the root cert are the same as any of the user-added ones from the OS trust store.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants