Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add docs to Profile Plotter #176

Open
bemcdonnell opened this issue Jan 4, 2023 · 2 comments
Open

add docs to Profile Plotter #176

bemcdonnell opened this issue Jan 4, 2023 · 2 comments

Comments

@bemcdonnell
Copy link
Member

This can be completed after #174 and #155 (planning)

@wraseman
Copy link

I can create an example to include in the docs, I just need to figure out how to deal with an error in build_profile_plot() first. When I try to use the from swmmio import build_profile_plot, find_network_trace code referenced in the pyswmm/pyswmm#531 ticket, I get an error. The issue is that there is no Type attribute associated with links.loc[link_id] and there are several locations where the logic in build_profile_plot() and private methods associated with it use links.loc[link_id].Type to determine whether the link is a conduit, weir, orifice, pump, or outlet. Based on the type of link, it extracts the length information differently.

@bemcdonnell
Copy link
Member Author

@wraseman are you using one of the examples on the PySWMM website?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants