commit b9518ac28 (add support for octets starting with 0x) what for?

[kixiro]

When I generate an attribute User-Password (CHAP), I get string start with '0x'. This leads to error:

  File "/usr/local/lib/python2.7/dist-packages/pyrad/packet.py", line 150, in _EncodeKeyValues
    return (key, [self._EncodeValue(attr, v) for v in values])
  File "/usr/local/lib/python2.7/dist-packages/pyrad/packet.py", line 123, in _EncodeValue
    result = tools.EncodeAttr(attr.type, value)
  File "/usr/local/lib/python2.7/dist-packages/pyrad/tools.py", line 178, in EncodeAttr
    return EncodeOctets(value)
  File "/usr/local/lib/python2.7/dist-packages/pyrad/tools.py", line 26, in EncodeOctets
    return binascii.unhexlify(hexstring)
TypeError: Odd-length string

Can this exception be put into a separate function?

[kixiro]

I did not correctly generate CHAP ID
can be closed

[kixiro]

No...

IF CHAP ID = 48
then

struct.pack('B', 48)
'0'

And first code md5 password = 'x' (code 120)
Attribute CHAP-Password startswith(b'0x') and get error "Odd-length string"
tools.py:

 24     if str.startswith(b'0x'):
 25         hexstring = str.split(b'0x')[1]
 26         return binascii.unhexlify(hexstring)

[GIC-de]

Can you please share some example code?