Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pypeit_sensfunc does not currently work on OneSpec files, but this is necessary for e.g. MOSFIRE long2pos. #1886

Open
jhennawi opened this issue Dec 29, 2024 · 0 comments

Comments

@jhennawi
Copy link
Collaborator

Hi All,

Leonor Arriscado pointed out this issue with PypeIt which I think she also brought up to @debora-pe in the User Slack. Basically, if one is using MOSFIRE long2pos to observe standards at different mask locations, then one wants to coadd1d these standards to obtain a combined flux standard (in counts) and then run pypeit_sensfunc on the OneSpec file. However, pypeit_sensfunc does not accept OneSpec files but only spec1d files. It should be possible to run pypeit_sensfunc on OneSpec files (although obviously not for echelle sensitivity functions). There are some things to think about here since the sensfunc class uses the blaze optionally, and there is no blaze packaged with OneSpec files, but I don't think this is a significant drawback since one can simply compute sensitivity functions without the blaze. I think that the sensfunc class should be modified to accommodate OneSpec files.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant