Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Respect XDG_* environment settings on macOS #1642

Closed
Kentzo opened this issue Jul 25, 2024 · 7 comments
Closed

Respect XDG_* environment settings on macOS #1642

Kentzo opened this issue Jul 25, 2024 · 7 comments

Comments

@Kentzo
Copy link

Kentzo commented Jul 25, 2024

Currently Hatch disregards the XDG_* environment variables on macOS. This somewhat contradicts the manual that says:

Unix | $XDG_CONFIG_HOME/hatch (the XDG_CONFIG_HOME environment variable default is ~/.config)

FWIW pipx respects this variables on macOS.

@ofek
Copy link
Collaborator

ofek commented Jul 26, 2024

macOS does not use that as it is not a standard on that platform. The documentation does say the right thing as far as I can tell:

image

@ofek ofek closed this as completed Jul 26, 2024
@Kentzo
Copy link
Author

Kentzo commented Jul 26, 2024

macOS is a UNIX environment, hence I expected the last line to apply.

What harm is there to support users who follow XDG Base Directory Specification on macOS? Plenty of apps support it just fine.

@ofek
Copy link
Collaborator

ofek commented Jul 26, 2024

tox-dev/platformdirs#4

@Kentzo
Copy link
Author

Kentzo commented Jul 26, 2024

I'm not sure whether this thread is for or against support of the XDG_ variables. Could you link a particular comment that represents your view? The way I read it, it was just a personal choice of the maintainer… However, that being the pypa/hatch I was expecting a more careful consideration.

As it stands, I was able to get what I want by adjusting the HATCH_* envionment variables. However I'm left puzzled why it was necessary in the first place.

@ofek
Copy link
Collaborator

ofek commented Jul 26, 2024

Sorry for not being clear, I linked that because it is the dependency we use so whatever it supports would be what Hatch supports and nothing more.

@ofek
Copy link
Collaborator

ofek commented Jul 26, 2024

My opinion is here: tox-dev/platformdirs#4 (comment)

@Kentzo
Copy link
Author

Kentzo commented Jul 26, 2024

Sorry for not being clear, I linked that because it is the dependency we use so whatever it supports would be what Hatch supports and nothing more.

Ah I see, thank you for clarification.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants