Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update __array__ signatures with copy #9529

Merged
merged 11 commits into from
Sep 25, 2024
Merged

Conversation

Illviljan
Copy link
Contributor

@Illviljan Illviljan commented Sep 21, 2024

Align all __array__-methods according to the new signature.
mypy can raise very hard to read errors if these are not correct, see #9237 for an example.

References:

@Illviljan Illviljan changed the title Update __array__ with copy Update __array__ signatures with copy Sep 21, 2024
@keewis
Copy link
Collaborator

keewis commented Sep 21, 2024

can you also remove the warning ignore in pyproject.toml, please?

Copy link
Contributor

@dcherian dcherian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for taking this on!

@dcherian dcherian merged commit ea06c6f into pydata:main Sep 25, 2024
28 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants