Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

release of 0.15.0 was blocked by myst #1622

Closed
12rambau opened this issue Jan 4, 2024 · 3 comments · Fixed by #1623
Closed

release of 0.15.0 was blocked by myst #1622

12rambau opened this issue Jan 4, 2024 · 3 comments · Fixed by #1623
Assignees
@12rambau
Labels
impact: block-release Should block a release from happening. Only use if this is a critical problem we don't want to ship kind: bug Something isn't working tag: CI Pull requests that update GitHub Actions code

Comments

@12rambau
Copy link
Collaborator

12rambau commented Jan 4, 2024

myst is triggering a new bug in our CI when used with 3.12. This bug is non existent with other Python Versions

https://github.com/pydata/pydata-sphinx-theme/actions/runs/7408284101

Unexpected warning: WARNING: The config value `myst_enable_extensions' has type `list'; expected `Any'.

It confirms I need to finish #1530 but in the meantime lets pin myst version to a working number so we can release v0.15.1
@12rambau 12rambau added kind: bug Something isn't working impact: block-release Should block a release from happening. Only use if this is a critical problem we don't want to ship tag: CI Pull requests that update GitHub Actions code labels Jan 4, 2024
@12rambau 12rambau self-assigned this Jan 4, 2024
@12rambau 12rambau mentioned this issue Jan 4, 2024
Merged
@drammock
Copy link
Collaborator

drammock commented Jan 4, 2024

This is not a myst-parser problem but rather a sphinx problem. See similar issues that have come up before: sphinx-doc/sphinx#9188

@drammock
Copy link
Collaborator

drammock commented Jan 4, 2024

(notice that myst-parser is version 2.0.0 in both the passing python 3.9 build and the failing python 3.12 build). The difference is Sphinx 6.1.0 vs 7.3.0

@12rambau
Copy link
Collaborator Author

12rambau commented Jan 4, 2024

yep I saw it afterward when I looked into the WARNING in detail

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@12rambau 12rambau

Labels
impact: block-release Should block a release from happening. Only use if this is a critical problem we don't want to ship kind: bug Something isn't working tag: CI Pull requests that update GitHub Actions code
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: drop the dev test 12rambau/pydata-sphinx-theme
2 participants
@drammock @12rambau