Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: modify remove_filtered_policy method to support filtering of empty strings #12

Merged
merged 3 commits into from
Oct 26, 2024

Conversation

sanguinedab
Copy link
Contributor

Modify remove_filtered_policy method to support filtering of empty strings

such as
enforcer.remove_filtered_policy(0, "alice", "", "read") # The obj can be an empty string representing any

And I looked at the official documentation and other SDKs (e.g. golang version)
image

@CLAassistant
Copy link

CLAassistant commented Oct 22, 2024

CLA assistant check
All committers have signed the CLA.

@leeqvip
Copy link
Contributor

leeqvip commented Oct 23, 2024

@sanguinedab Please fix
image

fix format
@sanguinedab
Copy link
Contributor Author

sanguinedab commented Oct 23, 2024

Please fix 图像
Ok, I fixed this format

@leeqvip
Copy link
Contributor

leeqvip commented Oct 25, 2024

@sanguinedab The linter still fails

@sanguinedab sanguinedab changed the title Modify remove_filtered_policy method to support filtering of empty strings fix: modify remove_filtered_policy method to support filtering of empty strings Oct 25, 2024
@sanguinedab
Copy link
Contributor Author

@sanguinedab The linter still fails

Sorry I fixed it

Does the Semantic PR specification need to be changed, sorry I don't know much about this specification, I changed my title with reference to other successful PRs

@leeqvip leeqvip merged commit 37e0561 into pycasbin:master Oct 26, 2024
11 of 12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants