-
-
Notifications
You must be signed in to change notification settings - Fork 553
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix CasADI path and disable IREE for MacOS #4528
Conversation
@agriyakhetarpal, @MarcBerliner Not perfect, but a step in the correct direction until I can finish #4487 |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #4528 +/- ##
========================================
Coverage 99.42% 99.42%
========================================
Files 299 299
Lines 22715 22717 +2
========================================
+ Hits 22584 22586 +2
Misses 131 131 ☔ View full report in Codecov by Sentry. |
0e9f521
to
77e581b
Compare
I will deal with the lychee issues later, since that is not connected to this PR. We have entirely too many links that break |
* Add a path for CasADI * Disable IREE for MacOS * style: pre-commit fixes * Update changelog * Style * Attempting to fix link issues * Attempting to fix link issues * Fix formatting --------- Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Description
Quick fixes for the issues with CasADI and IREE.
Related #4524
Related #4521
Type of change
The CasADI fix should work for MacOS and Linux builds, but does not fix Windows issues.
Key checklist:
$ pre-commit run
(or$ nox -s pre-commit
) (see CONTRIBUTING.md for how to set this up to run automatically when committing locally, in just two lines of code)$ python run-tests.py --all
(or$ nox -s tests
)$ python run-tests.py --doctest
(or$ nox -s doctests
)You can run integration tests, unit tests, and doctests together at once, using
$ python run-tests.py --quick
(or$ nox -s quick
).Further checks: