Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix CasADI path and disable IREE for MacOS #4528

Merged
merged 9 commits into from
Oct 18, 2024

Conversation

kratman
Copy link
Contributor

@kratman kratman commented Oct 18, 2024

Description

Quick fixes for the issues with CasADI and IREE.

Related #4524
Related #4521

Type of change

The CasADI fix should work for MacOS and Linux builds, but does not fix Windows issues.

  • Bug fix (non-breaking change which fixes an issue)

Key checklist:

  • No style issues: $ pre-commit run (or $ nox -s pre-commit) (see CONTRIBUTING.md for how to set this up to run automatically when committing locally, in just two lines of code)
  • All tests pass: $ python run-tests.py --all (or $ nox -s tests)
  • The documentation builds: $ python run-tests.py --doctest (or $ nox -s doctests)

You can run integration tests, unit tests, and doctests together at once, using $ python run-tests.py --quick (or $ nox -s quick).

Further checks:

  • Code is commented, particularly in hard-to-understand areas
  • Tests added that prove fix is effective or that feature works

@kratman kratman self-assigned this Oct 18, 2024
@kratman kratman marked this pull request as ready for review October 18, 2024 16:10
@kratman
Copy link
Contributor Author

kratman commented Oct 18, 2024

@agriyakhetarpal, @MarcBerliner Not perfect, but a step in the correct direction until I can finish #4487

Copy link

codecov bot commented Oct 18, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.42%. Comparing base (82f7a0f) to head (77e581b).
Report is 1 commits behind head on develop.

Additional details and impacted files
@@           Coverage Diff            @@
##           develop    #4528   +/-   ##
========================================
  Coverage    99.42%   99.42%           
========================================
  Files          299      299           
  Lines        22715    22717    +2     
========================================
+ Hits         22584    22586    +2     
  Misses         131      131           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@kratman
Copy link
Contributor Author

kratman commented Oct 18, 2024

I will deal with the lychee issues later, since that is not connected to this PR. We have entirely too many links that break

@kratman kratman requested a review from MarcBerliner October 18, 2024 16:50
CHANGELOG.md Show resolved Hide resolved
@kratman kratman merged commit e52a406 into pybamm-team:develop Oct 18, 2024
24 of 26 checks passed
@kratman kratman deleted the fix/casadiPath branch November 7, 2024 16:36
pkalbhor pushed a commit to pkalbhor/PyBaMM that referenced this pull request Nov 15, 2024
* Add a path for CasADI

* Disable IREE for MacOS

* style: pre-commit fixes

* Update changelog

* Style

* Attempting to fix link issues

* Attempting to fix link issues

* Fix formatting

---------

Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants