From 3198902cf6cc4189fce68cbdc169341dd01e610d Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Piotr=20Wo=CC=81jcik?=
 <3044353+pwojcikdev@users.noreply.github.com>
Date: Wed, 24 Jan 2024 11:23:25 +0100
Subject: [PATCH] LAZY OBJECT STREAMING

---
 nano/lib/logging.hpp       |  8 ++------
 nano/lib/object_stream.hpp | 40 +++++++++++++++++++++++++++++++++-----
 2 files changed, 37 insertions(+), 11 deletions(-)

diff --git a/nano/lib/logging.hpp b/nano/lib/logging.hpp
index dbb986f88e..e9f8d412c4 100644
--- a/nano/lib/logging.hpp
+++ b/nano/lib/logging.hpp
@@ -9,6 +9,7 @@
 #include <shared_mutex>
 #include <sstream>
 
+#include <fmt/ostream.h>
 #include <spdlog/spdlog.h>
 
 namespace nano::log
@@ -146,12 +147,7 @@ class logger final
 		auto logger = get_logger (type);
 		if (logger.should_log (spdlog::level::trace))
 		{
-			std::stringstream ss;
-
-			nano::object_stream obs{ ss };
-			(obs.write (args.name, args.value), ...);
-
-			logger.trace ("\"{}\" {}", to_string (detail), ss.str ());
+			logger.trace ("\"{}\" {}", to_string (detail), nano::object_stream_formatter{ std::forward<Args> (args)... });
 		}
 	}
 
diff --git a/nano/lib/object_stream.hpp b/nano/lib/object_stream.hpp
index 60ee70408d..a7554657d0 100644
--- a/nano/lib/object_stream.hpp
+++ b/nano/lib/object_stream.hpp
@@ -8,6 +8,7 @@
 #include <string_view>
 #include <type_traits>
 
+#include <fmt/ostream.h>
 #include <magic_enum.hpp>
 
 namespace nano
@@ -44,16 +45,14 @@ class array_stream;
  */
 
 template <typename T>
-concept object_streamable = requires (T const & obj, object_stream & obs)
-{
+concept object_streamable = requires (T const & obj, object_stream & obs) {
 	{
 		obj (obs)
 	};
 };
 
 template <typename T>
-concept array_streamable = requires (T const & obj, array_stream & ars)
-{
+concept array_streamable = requires (T const & obj, array_stream & ars) {
 	{
 		obj (ars)
 	};
@@ -180,8 +179,39 @@ class root_object_stream : private object_stream_base
 	void write (Value const & value);
 };
 
+/**
+ * Wraps `Args &&... args` and provides a `<< (std::ostream &, ...)` operator that writes the arguments to the stream in a lazy manner.
+ */
+template <class... Args>
+struct object_stream_formatter
+{
+	std::tuple<Args...> args;
+
+	explicit object_stream_formatter (Args &&... args) :
+		args{ std::forward<Args> (args)... }
+	{
+	}
+
+	friend std::ostream & operator<< (std::ostream & os, object_stream_formatter<Args...> const & self)
+	{
+		object_stream obs{ os };
+		std::apply ([&obs] (auto &&... args) {
+			((obs.write (args.name, args.value)), ...);
+		},
+		self.args);
+		return os;
+	}
+};
+
+// Needed for fmt formatting, uses the ostream operator under the hood
+template <class... Args>
+auto format_as (object_stream_formatter<Args...> const & val)
+{
+	return fmt::streamed (val);
+}
+
 /*
- * Impl
+ * implementation
  */
 
 template <class Value>