Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[DOCS]: Screen reader is not announcing the descriptive information for the ‘Here’ link. #4258

Closed
Anshi0420 opened this issue Aug 10, 2023 · 6 comments · Fixed by #4386
Closed

[DOCS]: Screen reader is not announcing the descriptive information for the ‘Here’ link. #4258

Anshi0420 opened this issue Aug 10, 2023 · 6 comments · Fixed by #4386
Assignees
@maraah1
Labels
A11ySev3 Accessibility Team tag - P3 items A11yTTValidated Accessibility team tag for closed bugs A11yWCAG Accessibility Team tag - Web Content Accessibility Guidelines Accessibility [E+D] Issues found by the accessibility E+D Team at Microsoft bug 🐛 CT-July23 CT-June24 HCL-E+D needs attention 👋 needs triage 🔍 Product-PWABuilder For Tracking PWABuilder bugs by Accessibility E+D team PWABuilder_Web

Comments

@Anshi0420
Copy link
Collaborator

Anshi0420 commented Aug 10, 2023 •
edited
Loading

What happened?

Screen reader is not announcing the descriptive information for the ‘Here’ link, which is present on the page multiple times, it is announcing as ‘Link here’.

How do we reproduce the behavior?

Repro steps:

  1. Open the URL: PWABuilder - Meta Quest in edge dev browser and login with v-.
  2. Turn on the screen reader through Ctrl+ Windows+ Enter key.
  3. Navigate to the ‘Here’ link through tab key.
  4. Observe the issue.

What do you expect to happen?

Screen reader should announce the descriptive information for the ‘Here’ link. Screen reader should announce as ‘Follow the instruction on link here’.

What environment were you using?

Test Environment:
OS: Windows11
OS Version: 23H2 (Build 25905.1000)
Browser: Edge Dev (Version 117.0.2007.0 (Official build) dev (64-bit))
Screen reader: Narrator

Additional context

Notes:

  1. Same issue is repro for Quick Start link at https://docs.pwabuilder.com/#/
  2. Both the issue repro at every pages where they are present.
  3. Issue repro for all the links which appears multiple times at the UI.

User Impact:
Screen reader users will get impacted as users will not be able to the purpose of the link and will not be able to interact or make track of the content properly.

WCAG reference link:
Understanding Success Criterion 2.4.9: Link Purpose (Link Only) | WAI | W3C

Attachments:

Screen.reader.is.not.announcing.the.descriptive.information.for.the.Here.link.mp4
MicrosoftTeams-image
@Anshi0420 Anshi0420 added bug 🐛 needs triage 🔍 A11yWCAG Accessibility Team tag - Web Content Accessibility Guidelines Accessibility [E+D] Issues found by the accessibility E+D Team at Microsoft A11ySev2 Accessibility Team tag - P2 items Product-PWABuilder For Tracking PWABuilder bugs by Accessibility E+D team HCL-E+D CT-July23 labels Aug 10, 2023
@Suriya617 Suriya617 mentioned this issue Aug 17, 2023
Closed
@microsoft-github-policy-service
Copy link
Contributor

This issue has been marked as "needs attention 👋" since it has not been triaged for 7 days. Please triage the issue .

1 similar comment
@microsoft-github-policy-service
Copy link
Contributor

This issue has been marked as "needs attention 👋" since it has not been triaged for 7 days. Please triage the issue .

@Jaylyn-Barbee Jaylyn-Barbee changed the title [PWA builder-Blog]: Screen reader is not announcing the descriptive information for the ‘Here’ link. [DOCS]: Screen reader is not announcing the descriptive information for the ‘Here’ link. Aug 28, 2023
@microsoft-github-policy-service
Copy link
Contributor

This issue has been marked as "needs attention 👋" since it has not been triaged for 7 days. Please triage the issue .

1 similar comment
@microsoft-github-policy-service
Copy link
Contributor

This issue has been marked as "needs attention 👋" since it has not been triaged for 7 days. Please triage the issue .

@maraah1 maraah1 mentioned this issue Sep 20, 2023
Merged
3 tasks
@maraah1 maraah1 moved this to In Review 🤔 in PWABuilder Sep 20, 2023
@maraah1 maraah1 self-assigned this Sep 20, 2023
@maraah1 maraah1 linked a pull request Sep 20, 2023 that will close this issue
More descriptive "here" text across all docs #4386
Merged
3 tasks
@github-project-automation github-project-automation bot moved this from In Review 🤔 to Done ✔️ in PWABuilder Sep 21, 2023
@Jaylyn-Barbee Jaylyn-Barbee reopened this Sep 21, 2023
@github-project-automation github-project-automation bot moved this from Done ✔️ to Todo 📃 in PWABuilder Sep 21, 2023
@maraah1 maraah1 moved this from Todo 📃 to In Review 🤔 in PWABuilder Sep 21, 2023
github-merge-queue bot pushed a commit that referenced this issue Sep 21, 2023
@maraah1 @Jaylyn-Barbee
More descriptive "here" text across all docs (#4386)
c791853 
fixes #4258 
<!-- Link to relevant issue (for ex: "fixes #1234") which will
automatically close the issue once the PR is merged -->

## PR Type
<!-- Please uncomment one ore more that apply to this PR -->

 Bugfix
<!-- - Feature -->
Code style update (formatting)
<!-- - Refactoring (no functional changes, no api changes) -->
<!-- - Build or CI related changes -->
<!-- - Documentation content changes -->
<!-- - Sample app changes -->
<!-- - Other... Please describe: -->


## Describe the current behavior?
<!-- Please describe the current behavior that is being modified or link
to a relevant issue. -->


## Describe the new behavior?
More descriptive "here" text across all docs

## PR Checklist

- [ ] Test: run `npm run test` and ensure that all tests pass
- [ ] Target main branch (or an appropriate release branch if
appropriate for a bug fix)
- [ ] Ensure that your contribution follows [standard accessibility
guidelines](https://docs.microsoft.com/en-us/microsoft-edge/accessibility/design).
Use tools like https://webhint.io/ to validate your changes.


## Additional Information

Co-authored-by: Jaylyn Barbee <[email protected]>
@Jaylyn-Barbee Jaylyn-Barbee mentioned this issue Oct 16, 2023
Merged
3 tasks
@Jaylyn-Barbee Jaylyn-Barbee moved this from In Review 🤔 to Done ✔️ in PWABuilder Oct 16, 2023
github-merge-queue bot pushed a commit that referenced this issue Oct 16, 2023
@Jaylyn-Barbee @jgw96
@khmyznikov @nmetulev @maraah1 @dependabot @adolfdaniel @zateutsch @beth-panx @vipul-bhojwani @amrutha95 @FANMixco @ybot1122 @microsoft-github-policy-service @dargmuesli @SirajChokshi
Main <-- Staging (#4456)
a26ff48 
fixes/features (should be multiple, add to the list)
1. App Capabilities:
#4034
2. Accessibility issues: #4258, #4259, #4239, #4240

## Describe the current behavior?
<!-- Please describe the current behavior that is being modified or link
to a relevant issue. -->
1. App Capabilities are mixed in with manifest and SW fields and there
is no easy way to discover and learn about them
2. Accessibility Issues from most recent pass

## Describe the new behavior?
1. New designs to isolate app capabilities and give our users more
information about what they are and how to implement them.
2. Fixed those issues

## PR Checklist
- [x] Test: run `npm run test` and ensure that all tests pass
- [x] Target main branch (or an appropriate release branch if
appropriate for a bug fix)
- [x] Ensure that your contribution follows [standard accessibility
guidelines](https://docs.microsoft.com/en-us/microsoft-edge/accessibility/design).
Use tools like https://webhint.io/ to validate your changes.

## Additional Information
1. Known issue: #4453
waiting on dependency
(shoelace-style/shoelace#1612).
2. No additional context

---------

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: Justin Willis <[email protected]>
Co-authored-by: Gleb Khmyznikov <[email protected]>
Co-authored-by: Nikola Metulev <[email protected]>
Co-authored-by: Mara'ah Lee <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Adolf Daniel <[email protected]>
Co-authored-by: Justin Willis (HE / HIM) <[email protected]>
Co-authored-by: Zach Teutsch <[email protected]>
Co-authored-by: Beth Pan <[email protected]>
Co-authored-by: vipul-bhojwani <[email protected]>
Co-authored-by: Amrutha Srinivasan <[email protected]>
Co-authored-by: Federico Navarrete <[email protected]>
Co-authored-by: Toby Liu <[email protected]>
Co-authored-by: microsoft-github-policy-service[bot] <77245923+microsoft-github-policy-service[bot]@users.noreply.github.com>
Co-authored-by: Amrutha Srinivasan <[email protected]>
Co-authored-by: Jonas Thelemann <[email protected]>
Co-authored-by: Siraj Chokshi <[email protected]>
@Anshi0420
Copy link
Collaborator Author

Issue is still repro at latest environment.

2024-06-26.12-30-17.mp4

@Anshi0420 Anshi0420 reopened this Jun 26, 2024
@github-project-automation github-project-automation bot moved this from Done ✔️ to Todo 📃 in PWABuilder Jun 26, 2024
@Suriya617 Suriya617 mentioned this issue Jun 27, 2024
Closed
@Suriya617 Suriya617 added A11ySev3 Accessibility Team tag - P3 items and removed A11ySev2 Accessibility Team tag - P2 items labels Jun 27, 2024
@Suriya617
Copy link
Collaborator

As these are not reflecting in scorecard. Tracking with #4764

@github-project-automation github-project-automation bot moved this from Todo 📃 to Done ✔️ in PWABuilder Jun 28, 2024
@Suriya617 Suriya617 added the A11yTTValidated Accessibility team tag for closed bugs label Jun 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@maraah1 maraah1

Labels
A11ySev3 Accessibility Team tag - P3 items A11yTTValidated Accessibility team tag for closed bugs A11yWCAG Accessibility Team tag - Web Content Accessibility Guidelines Accessibility [E+D] Issues found by the accessibility E+D Team at Microsoft bug 🐛 CT-July23 CT-June24 HCL-E+D needs attention 👋 needs triage 🔍 Product-PWABuilder For Tracking PWABuilder bugs by Accessibility E+D team PWABuilder_Web
Projects
PWABuilder
Status: Done ✔️
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

More descriptive "here" text across all docs pwa-builder/PWABuilder
4 participants
@maraah1 @Jaylyn-Barbee @Suriya617 @Anshi0420