Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

images are broken #350

Open
jab opened this issue Aug 3, 2024 · 1 comment
Open

images are broken #350

jab opened this issue Aug 3, 2024 · 1 comment
Labels
🙏 help wanted needs PR or help on decision

Comments

@jab
Copy link

jab commented Aug 3, 2024

https://raw.githubusercontent.com/pure-fish/pure/master/README.md and https://pure-fish.github.io/pure/ currently include screenshot images that are not working, e.g.

<img width=440 src=https://camo.githubusercontent.com/be014be282ef66e5c5cad19458aa61d7df6865ecbe55bcc882e0d53580f81de9/68747470733a2f2f692e696d6775722e636f6d2f424878556f68522e706e67 alt="Pure with dark colorscheme">

renders like:

Pure with dark colorscheme

@edouard-lopez
Copy link
Member

Thanks for the feedback, I started working on screenshot generation during CI (see #345) but stopped.

In the meantime, I'm open for a PR placing manually generated screenshot in docs/assets/screenshots.
Old version are visible in #113

@edouard-lopez edouard-lopez added the 🙏 help wanted needs PR or help on decision label Dec 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🙏 help wanted needs PR or help on decision
Projects
None yet
Development

No branches or pull requests

2 participants