forked from OkapiLib/OkapiLib
-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
LoggerTests fail #8
Comments
These actually only fail on my machine. The LoggerTests use |
NoRePercussions
added a commit
to Buchholz-Robotics/OkapiLib
that referenced
this issue
Feb 9, 2023
The previous tests used a technically write-only stream in memory, which causes the tests to fail on some systems. Instead, we can use an `fmemopen` stream to ensure it is always readable.
NoRePercussions
added a commit
to Buchholz-Robotics/OkapiLib
that referenced
this issue
Feb 9, 2023
The previous tests used a technically write-only stream in memory, which causes the tests to fail on some systems. Instead, we can use an `fmemopen` stream to ensure it is always readable.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Describe the bug
The 5 logging type
LoggerTest
s fail.Inspection reveals that the
getline
fails:Flushing or rewinding the buffer does not help.
Additionally,
LoggerTest.TestLazyLogging
succeeds, but only because it does not test the output. To check if lazy logging actually works, it should probably test the output.Steps To Reproduce
Run the
LoggerTest
tests:Expected behavior
Tests should pass and getline should not fail to read from the file
Versions
OkapiLib 5 / PurdueSigBots maintenance fork
Additional Information
Compiled with Clang.
The text was updated successfully, but these errors were encountered: